Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a section about partial reads in Mount (Everest) docs #8724

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Add a section about partial reads in Mount (Everest) docs #8724

merged 4 commits into from
Feb 27, 2025
+16 −0

Conversation

yonipeleg33
Copy link
Contributor

Closes #8723

@yonipeleg33 yonipeleg33 added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog labels Feb 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

♻️ PR Preview 8a7a244 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

arielshaqed
arielshaqed approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approving for dev, but please wait for a review from @talSofer / product.

yonipeleg33 and others added 2 commits February 26, 2025 15:40
@yonipeleg33 @arielshaqed
accept Ariel's suggestion
29b169c 
Co-authored-by: Ariel Shaqed (Scolnicov) <[email protected]>
@yonipeleg33 @arielshaqed
accept Ariel's suggestion (2)
cb67f30 
Co-authored-by: Ariel Shaqed (Scolnicov) <[email protected]>
talSofer
talSofer approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@talSofer talSofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! added a minor comment

docs/reference/mount.md Outdated
When reading large files, Everest can fetch from lakeFS only the parts actually accessed.
This can be useful for streaming workloads or for applications handling file formats such as Parquet, m4a, zip, tar that do not need to read the entire file.

To enable partial reads, pass the `--partial-reads` flag to the `mount` (or `mount-server`) command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an example
everest mount bla bla --partial-reads

yonipeleg33
yonipeleg33 commented Feb 27, 2025
View reviewed changes
Copy link
Contributor Author

@yonipeleg33 yonipeleg33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @talSofer!
Fixed your comment, pulling once CI is done.

@yonipeleg33 yonipeleg33 merged commit 2727542 into master Feb 27, 2025
41 of 42 checks passed
@yonipeleg33 yonipeleg33 deleted the document-partial-reads branch February 27, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@talSofer talSofer talSofer approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add note about partial reads in mount docs
3 participants
@yonipeleg33 @arielshaqed @talSofer